From 2dc30596ef5248bb181d1d0f5a2872252291095f Mon Sep 17 00:00:00 2001 From: Mark van Renswoude Date: Tue, 26 Oct 2021 20:33:25 +0200 Subject: [PATCH] Check for ConvergeMethodName while loading flows is incorrect --- Tapeti.Flow/Default/FlowStore.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Tapeti.Flow/Default/FlowStore.cs b/Tapeti.Flow/Default/FlowStore.cs index 9f3b508..8b0aa96 100644 --- a/Tapeti.Flow/Default/FlowStore.cs +++ b/Tapeti.Flow/Default/FlowStore.cs @@ -86,6 +86,7 @@ namespace Tapeti.Flow.Default { // We could check all the things that are required for a continuation or converge method, but this should suffice // for the common scenario where you change code without realizing that it's signature has been persisted + // ReSharper disable once InvertIf if (validatedMethods.Add(metadata.MethodName)) { var methodInfo = MethodSerializer.Deserialize(metadata.MethodName); @@ -97,6 +98,7 @@ namespace Tapeti.Flow.Default throw new InvalidDataException($"Flow ID {flowId} references continuation method '{metadata.MethodName}' which no longer has a binding as a message handler (continuation Id = {continuationId})"); } + /* Disabled for now - the ConvergeMethodName does not include the assembly so we can't easily check it if (string.IsNullOrEmpty(metadata.ConvergeMethodName) || !validatedMethods.Add(metadata.ConvergeMethodName)) return; @@ -105,6 +107,7 @@ namespace Tapeti.Flow.Default throw new InvalidDataException($"Flow ID {flowId} references converge method '{metadata.ConvergeMethodName}' which no longer exists (continuation Id = {continuationId})"); // Converge methods are not message handlers themselves + */ }