From 38326bd328fa3200b1ec33163847ee0761e69914 Mon Sep 17 00:00:00 2001
From: Mark van Renswoude <mark@x2software.net>
Date: Thu, 10 Feb 2022 10:17:27 +0100
Subject: [PATCH] Removed ValueTask overload for parallel request Converge
 method

- Doesn't work with the current persisted flow state so it would require a refactoring and in-place conversion
---
 Tapeti.Flow/Default/FlowProvider.cs |  6 ------
 Tapeti.Flow/IFlowProvider.cs        | 13 -------------
 2 files changed, 19 deletions(-)

diff --git a/Tapeti.Flow/Default/FlowProvider.cs b/Tapeti.Flow/Default/FlowProvider.cs
index 509ab64..2fa8a2d 100644
--- a/Tapeti.Flow/Default/FlowProvider.cs
+++ b/Tapeti.Flow/Default/FlowProvider.cs
@@ -362,12 +362,6 @@ namespace Tapeti.Flow.Default
                 return BuildYieldPoint(continuation, false, noRequestsBehaviour);
             }
 
-            public IYieldPoint Yield(Func<ValueTask<IYieldPoint>> continuation, FlowNoRequestsBehaviour noRequestsBehaviour = FlowNoRequestsBehaviour.Exception)
-            {
-                throw new NotImplementedException();
-            }
-
-
             public IYieldPoint YieldSync(Func<IYieldPoint> continuation, FlowNoRequestsBehaviour noRequestsBehaviour = FlowNoRequestsBehaviour.Exception)
             {
                 return BuildYieldPoint(continuation, true, noRequestsBehaviour);
diff --git a/Tapeti.Flow/IFlowProvider.cs b/Tapeti.Flow/IFlowProvider.cs
index 3ac98de..b7e18df 100644
--- a/Tapeti.Flow/IFlowProvider.cs
+++ b/Tapeti.Flow/IFlowProvider.cs
@@ -230,19 +230,6 @@ namespace Tapeti.Flow
         /// <param name="noRequestsBehaviour">How the Yield method should behave when no requests have been added to the parallel request builder.</param>
         IYieldPoint Yield(Func<Task<IYieldPoint>> continuation, FlowNoRequestsBehaviour noRequestsBehaviour = FlowNoRequestsBehaviour.Exception);
 
-        /// There is no Sync overload with an IFlowParallelRequest parameter, as the AddRequest methods for that are
-        /// async, so you should always await them.
-        /// <summary>
-        /// Constructs an IYieldPoint to continue the flow when responses arrive.
-        /// The continuation method is called when all responses have arrived.
-        /// Response handlers and the continuation method are guaranteed thread-safe access to the
-        /// controller and can store state.
-        /// Used for asynchronous continuation methods.
-        /// </summary>
-        /// <param name="continuation">The converge continuation method to be called when all responses have been handled.</param>
-        /// <param name="noRequestsBehaviour">How the Yield method should behave when no requests have been added to the parallel request builder.</param>
-        IYieldPoint Yield(Func<ValueTask<IYieldPoint>> continuation, FlowNoRequestsBehaviour noRequestsBehaviour = FlowNoRequestsBehaviour.Exception);
-
         /// <summary>
         /// Constructs an IYieldPoint to continue the flow when responses arrive.
         /// The continuation method is called when all responses have arrived.