From bcd2cbed6991a293e97ff74525bb0d102adc83a6 Mon Sep 17 00:00:00 2001
From: Mark van Renswoude <mark@x2software.net>
Date: Mon, 27 May 2019 11:48:10 +0200
Subject: [PATCH] Removed MessageHandler attribute in favor of WithMembers on
 MessageController and Queue attributes

---
 Tapeti.Annotations/DurableQueueAttribute.cs     |  5 ++++-
 Tapeti.Annotations/DynamicQueueAttribute.cs     |  5 +++++
 .../MessageControllerAttribute.cs               |  2 +-
 Tapeti.Annotations/MessageHandlerAttribute.cs   | 17 -----------------
 Tapeti.Annotations/RequestAttribute.cs          |  3 +++
 5 files changed, 13 insertions(+), 19 deletions(-)
 delete mode 100644 Tapeti.Annotations/MessageHandlerAttribute.cs

diff --git a/Tapeti.Annotations/DurableQueueAttribute.cs b/Tapeti.Annotations/DurableQueueAttribute.cs
index 281d91f..8971044 100644
--- a/Tapeti.Annotations/DurableQueueAttribute.cs
+++ b/Tapeti.Annotations/DurableQueueAttribute.cs
@@ -14,9 +14,12 @@ namespace Tapeti.Annotations
     /// for deploy-time management of durable queues (shameless plug intended).
     /// </remarks>
     [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method)]
-    [MeansImplicitUse]
+    [MeansImplicitUse(ImplicitUseTargetFlags.WithMembers)]
     public class DurableQueueAttribute : Attribute
     {
+        /// <summary>
+        /// Specifies the name of the durable queue (must already be declared).
+        /// </summary>
         public string Name { get; set; }
 
 
diff --git a/Tapeti.Annotations/DynamicQueueAttribute.cs b/Tapeti.Annotations/DynamicQueueAttribute.cs
index 3743edf..240b001 100644
--- a/Tapeti.Annotations/DynamicQueueAttribute.cs
+++ b/Tapeti.Annotations/DynamicQueueAttribute.cs
@@ -12,6 +12,11 @@ namespace Tapeti.Annotations
     [MeansImplicitUse]
     public class DynamicQueueAttribute : Attribute
     {
+        /// <summary>
+        /// An optional prefix. If specified, Tapeti will compose the queue name using the
+        /// prefix and a unique ID. If not specified, an empty queue name will be passed
+        /// to RabbitMQ thus letting it create a unique queue name.
+        /// </summary>
         public string Prefix { get; set; }
 
 
diff --git a/Tapeti.Annotations/MessageControllerAttribute.cs b/Tapeti.Annotations/MessageControllerAttribute.cs
index 150fefc..6a18416 100644
--- a/Tapeti.Annotations/MessageControllerAttribute.cs
+++ b/Tapeti.Annotations/MessageControllerAttribute.cs
@@ -9,7 +9,7 @@ namespace Tapeti.Annotations
     /// when using the RegisterAllControllers method. It is not required when manually registering a controller.
     /// </summary>
     [AttributeUsage(AttributeTargets.Class)]
-    [MeansImplicitUse]
+    [MeansImplicitUse(ImplicitUseTargetFlags.WithMembers)]
     public class MessageControllerAttribute : Attribute
     {
     }
diff --git a/Tapeti.Annotations/MessageHandlerAttribute.cs b/Tapeti.Annotations/MessageHandlerAttribute.cs
deleted file mode 100644
index d13724e..0000000
--- a/Tapeti.Annotations/MessageHandlerAttribute.cs
+++ /dev/null
@@ -1,17 +0,0 @@
-using System;
-using JetBrains.Annotations;
-
-namespace Tapeti.Annotations
-{
-    /// <inheritdoc />
-    /// <summary>
-    /// This attribute does nothing in runtime and is not required. It is only used as
-    /// a hint to ReSharper, and maybe developers as well, to indicate the method is
-    /// indeed used.
-    /// </summary>
-    [AttributeUsage(AttributeTargets.Method)]
-    [MeansImplicitUse]
-    public class MessageHandlerAttribute : Attribute
-    {
-    }
-}
diff --git a/Tapeti.Annotations/RequestAttribute.cs b/Tapeti.Annotations/RequestAttribute.cs
index 2f14097..f298c50 100644
--- a/Tapeti.Annotations/RequestAttribute.cs
+++ b/Tapeti.Annotations/RequestAttribute.cs
@@ -13,6 +13,9 @@ namespace Tapeti.Annotations
     [AttributeUsage(AttributeTargets.Class)]
     public class RequestAttribute : Attribute
     {
+        /// <summary>
+        /// The type of the message class which must be returned as the response.
+        /// </summary>
         public Type Response { get; set; }
     }
 }